-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #2015 #49
fix #2015 #49
Conversation
Thanks for fix :) Just curious, will this fix koreader/koreader#2021 too? |
no. I'm working on #2021 but still not very clear. I found that the position of the highlighted area need to consider left and top paddings(and borders). But I still dont know why it will appear on other pages. |
I am not very sure why this is happening either. I was looking at this, but then got distracted by segfaults in kobo screenshot and suspension. @Hzj-jie put out a minimal reproducible same txt file in koreader/koreader#1944 (see the screenshot). Using this test sample should help us find the bug easier than debugging on a real epub. I will also help take a look at this after I figure out what's causing the segfaults in kobo. |
I think these code are not so mature as the coolreader itself does not use them. its own bookmark is implemented in another way. |
You mean the hightlight code path? |
I searched the whole project for ldomXRange.getRect and it was not called once. Maybe I searched wrong name? |
add margins in elementFromPoint() and some changes about page-break-after