Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove too generic hyphenation rule for Russian "э" vowel #564

Closed
wants to merge 1 commit into from

Conversation

dmalinovsky
Copy link
Contributor

@dmalinovsky dmalinovsky commented May 3, 2024

With this rule the engine makes hyphenations in unexpected places:

With the rule Without it

It also makes hyphens in the words like this: "фл-эшка" ("fl-ash drive"), "Бл-эк" ("Bl-ack"), "Гр-эй" ("Gr-ay").

@hius07, can you please take a look or recommend another reviewer?


This change is Reviewable

@hius07
Copy link
Member

hius07 commented May 3, 2024

Are there examples of usual words affected by the pattern?

@dmalinovsky
Copy link
Contributor Author

I didn’t find a way to run the hyphenation engine manually, but I imagine it may affect the words like “поэзия” or “маэстро”: https://gramota.ru/biblioteka/spravochniki/pravila-russkoj-orfografii-i-punktuacii/bukva-e

@poire-z
Copy link
Contributor

poire-z commented May 3, 2024

Feels odd you need to update such a generic pattern - and that Russian readers/writters (using KOReader or Libreoffice or other softwares) didn't feel the need to change that for 20 years :)
Would be goot to check how it is in the current free hyph dicts used by such projects. Some links in #373.
And for other russian readers to use these modified .pattern files on their current reading for some time.

(Usually, at least for French, we have just added "longer" patterns for "strange" words these last years.)
Also, for quick checking individual words: https://www.ushuaia.pl/hyphen/

@dmalinovsky
Copy link
Contributor Author

This pattern negatively affects mostly foreign names, which are not in the dictionaries.

Thanks for the suggestion, @poire-z, I’ll work on adding longer patterns instead of this PR.

@dmalinovsky dmalinovsky closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants