update leptonica, tesseract, and libk2pdfopt #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency for newer tesseract versions.
You mean on a device I presume? |
benoit-pierre
force-pushed
the
pr/update_leptonica_tesseract_libk2pdfopt
branch
from
4f81d97
to
588c233
Compare
Mainly with the emulator. |
Frenzie
approved these changes
May 31, 2024
- bump leptonica to 1.84.1 - bump tesseract to 5.3.4 - bump libk2pdfopt to 2.55
benoit-pierre
force-pushed
the
pr/update_leptonica_tesseract_libk2pdfopt
branch
from
588c233
to
b7d28fa
Compare
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
May 31, 2024
Preliminary bump (koreader/koreader-base#1800 will be included in #11930): - koreader/koreader-base#1790 - koreader/koreader-base#1795 - koreader/koreader-base#1796 - koreader/koreader-base#1797 - koreader/koreader-base#1798 - koreader/koreader-base#1799 - koreader/koreader-base#1801 - koreader/koreader-base#1802 - koreader/koreader-base#1803 - koreader/koreader-base#1804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on koreader/libk2pdfopt#49.
Thanks to some upstream cleanups in tesseract, the resulting code size (bss+data+text) is reduced by ~1.4-2.3 MB.
Note: tesseract is compiled with legacy engine support, which means the resulting mode after initialization will depend on the type of language data available:
Integermodels): run the LSTM line recognizer only.Floatmodels): same mode as above.AFAIK, there are no legacy only language files.
I tested both modes, English only with
tessdata&tessdata-fast, and it did not seem to make a difference (which might just mean that the fallback on legacy was never triggered). Disabling the legacy engine would save an additional ~500 KB. But I don't know if the new engine is (always) better, especially for other languages.The version used by Linux distributions seem to vary: for example Arch Linux is using the English
tessdatavariant, while Ubuntu usestessdata-fast. ¯\(ツ)/¯This change is