trim down libk2pdfopt #1837
Merged
trim down libk2pdfopt #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
pr/k2opt_trim
branch
from
3f5009d
to
13cc1ab
Compare
Only compile & export what's needed for koreader: reduce code size (bss+data+text) by ~3.5 MB and file size by ~315-405 KB.
It's only needed by libk2pdfopt: reduce code size (bss+data+text) by ~270-380 KB and file size by ~276-409 KB.
Go through a dedicated cmake file, so it can be used by an external cmake project.
NOTE: `bmp_bytewidth` is not used by the LUA code, but necessary for our `koreader-djvu` library.
Reduce code size (bss+data+text) by ~2-4 KB and file size by ~4-12 KB.
benoit-pierre
force-pushed
the
pr/k2opt_trim
branch
from
13cc1ab
to
f92f098
Compare
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 24, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 24, 2024
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on koreader/libk2pdfopt#53.
Impact on release builds code (bss+data+text) and file sizes:
This change is