Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor third-party bumps #1828

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Minor third-party bumps #1828

merged 3 commits into from
Jun 20, 2024

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jun 18, 2024

Nothing major in LuaJIT
And LPeg & LuaJSON because I noticed the lpeg update on Gentoo ;p.

I'm not even, sure we actually have anything that still uses laujson in front...


This change is Reviewable

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 18, 2024

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 18, 2024

I'm not even, sure we actually have anything that still uses luajson in front...

Oh, quite a lot of stuff actually...

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 18, 2024

And since we like shipping thirty different JSON parsers, I'll add that dksjon looks like a slightly less abandoned variant ;).

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

(IIRC, we still need lpeg for lua-Spore, though. EDIT: Nope ^^.).

@pazos
Copy link
Member

pazos commented Jun 18, 2024

Snark aside, there's a potential cleanup opportunity to drop luajson in favor of lunajson (or, well, rapidjson even) for the few things using it in main.

Do you mean

require("json")

or yet another implementation ?

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 18, 2024

Yeah, that's what tripped me up in saying we weren't using luajson anymore: I was looking for a require("luajson"), but that's indeed luajson ;).

@NiLuJe NiLuJe merged commit 66f19df into koreader:master Jun 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants