tesseract: disable debug fonts #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid spurious error traces: ``` Error in pixReadMemTiff: function not present Error in pixReadMem: tiff: no pix returned Error in pixaGenerateFontFromString: pix not made Error in bmfCreate: font pixa not made ```
Frenzie
reviewed
Jun 22, 2024
| DebugPixa() { | ||
| pixa_ = pixaCreate(0); | ||
| -#ifdef TESSERACT_DISABLE_DEBUG_FONTS | ||
| +#if 1//def TESSERACT_DISABLE_DEBUG_FONTS |
There was a problem hiding this comment.
Patching feels a bit convoluted compared to just setting it?
There was a problem hiding this comment.
There's no knob in the build system to enable the flag… And it's only used here, so it's actually easier then having to patch CMakeLists.txt, or create a dedicated toolchain file to tweak the compilation flags just for tesseract.
(I almost used something like set(CMAKE_C_FLAGS_INIT "$(strip $(CFLAGS)) $${CPPFLAGS} $${CFLAGS}") when generating the toolchain file to make it easier to tweak those).
Frenzie
approved these changes
Jun 22, 2024
NiLuJe
approved these changes
Jun 22, 2024
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Jun 24, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 24, 2024
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid spurious error traces:
This change is