MµPDF 1.14.0

[NiLuJe]

Here be dragons, a few API changes to pass some stuff by value instead of by reference...

And a buildsystem update, because of course. :D.

---

This change is 

[NiLuJe]

Special shout out to past self in #660 ;p.

[NiLuJe]

Sidebar: upstream's documentation is still abysmal, ripgrep is my best friend. As is landing by chance on the right commit message.

Which may very well mean that shit I may have missed will break.

And, let's face it, there's a 142% probability that I did miss something ;).

[NiLuJe]

Library authors: for the love of all that is holy, please document API changes in a clear, concise, and easy to find way.

[NiLuJe]

This makes everything fantastically opaque, not a fan, but hey. -_-".

[NiLuJe]

Pro tip: calling a function that doesn't exist will segfault! :D.

pdf_set_markup_appearance is gone.

[NiLuJe]

I have no idea how any of this is supposed to work, so, if anyone wants to take care of it, be my guest ;).

[NiLuJe]

Haven't hit an issue related to that yet, no ;).

…

On Fri, Nov 16, 2018, 13:45 Frans de Jonge ***@***.*** wrote: Quads instead of rects when highlighting and searching text. Is that the relevant part of the changelog? I don't know what quads are in this context but it sounds like it might very well break all of our assumptions, although if there were a pointer on how to *use* them it might still be easy to keep it all the same for the frontend by just passing a rectangle. But yeah… I don't have time to go code digging, atm and not much desire to do so on Sunday, at least this one. ;-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#762 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG1ZmWXGZw6WxdU5hIoJZJQSig4lWlTks5uvrNUgaJpZM4Yezpd> .

[NiLuJe]

(There's a link to the offending commit for the current issue in a comment added in the latest commit).

[Frenzie]

Good, that's one step closer. ;-)

[baskerville]

The following command might be helpful in knowing precisely how the API changed:

git diff 1.13.0..1.14.0 include

[NiLuJe]

My main concern is no longer ranting about undocumented changes, but instead figuring out the replacing API with zero knowledge of the PDF format :D.

[bahusoid]

for the love of all that is holy, please document API changes in a clear, concise, and easy to find way.

And voila MuPdf 1.15 is out with API changes :) At least made in 1.14

Regarding replacing API for pdf_set_markup_appearance.

Have you looked here (see how this new_annot is used)? I might be wrong but seems it contains similar logic that creates and manipulates with annotations. Looks like you need to simply call pdf_update_appearance instead plus:

• Line height/thickness seems be internalized (at least I didn't see it);
• for alpha setting call additionally pdf_set_annot_opacity;
• for color pdf_set_annot_color

At the end of manipulations it seems second call to pdf_update_appearance is required.

[NiLuJe]

Thanks for the heads up ;). That looks sensible, thanks!

This'll have to wait until k2pdfopt moves to this new MuPDF version, though ;). Provided the accompanying bump to tesseract and friends doesn't also drive me mad ;p.

[Frenzie]

1.16 comes with further significant API changes: https://github.com/ArtifexSoftware/mupdf/blob/97096297d409ec6f206298444ba00719607e8ba8/docs/api/changes.html

[NiLuJe]

No new k2pdfopt release yet, though, so 1.14 is still what it expects IIRC.

…

On Mon, Jul 29, 2019, 15:23 Frans de Jonge ***@***.***> wrote: 1.16 comes with further significant API changes: https://github.com/ArtifexSoftware/mupdf/blob/97096297d409ec6f206298444ba00719607e8ba8/docs/api/changes.html — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#762?email_source=notifications&email_token=AAA3KZW7RTOKOCWW4OCIOGLQB3VLRA5CNFSM4GD3HJO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3AV5RI#issuecomment-515989189>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA3KZSEKGALIWDHK5JFDITQB3VLRANCNFSM4GD3HJOQ> .

[Frenzie]

@NiLuJe I hope I merged it right; it was a quickie using the GH web GUI. k2pdfopt 2.52 just came out but it's still on MuPDF 1.14 I believe.

[NiLuJe]

I'll take a look at it sometime this week ;).

[roshavagarga]

@Frenzie @NiLuJe k2pdfopt 2.53 seems to have updated to MuPDF 1.17.

[NiLuJe]

@roshavagarga: Ah, now we're talking, thanks for the heads up!

I'll try to take a look at it Soon(TM) ;).

[NiLuJe]

Sidebar: soon may be late, because I won't be available for most of August ;p.

[Frenzie]

Well, have fun! ;-)

[Frenzie]

Superseded by #1203.