Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android]: Layout issues on Huawei P20 Pro #4584

Closed
pazos opened this issue Feb 12, 2019 · 1 comment · Fixed by koreader/android-luajit-launcher#113
Closed

[Android]: Layout issues on Huawei P20 Pro #4584

pazos opened this issue Feb 12, 2019 · 1 comment · Fixed by koreader/android-luajit-launcher#113
Labels
Android bug

Comments

@pazos
Copy link
Member

pazos commented Feb 12, 2019

  • KOReader version: current
  • Device: Huawei P20 Pro.

Reported by @wangkaibule on gitter

Issue

  1. Screen aspect ratio is more than 2:1, and KOReader doesn't fill all the space available. (Can't reproduce on the emulator)
  2. Errr, KOReader doesn't enter fullscreen until pause/resume is triggered. That is common for all devices with an action bar.

92fffjr2_o
@pazos pazos mentioned this issue Feb 12, 2019
Merged
@Frenzie
Copy link
Member

Frenzie commented Feb 12, 2019

Link to report

@Frenzie The content of both Koreader UI and book content are incomplete on my mobile phone, sorry I cannot upload any pictures at the moment. Also I have to touch the "paper" icon to activate the menu under the "cog" icon
And I'm afraid I can not find the "scroll mode" option

http://imgbox.com/92fFfJR2
The first picture shows the content is incomplete in landscape mode and the second picture shows the UI is incomplete in portrait mode

Frenzie added a commit to Frenzie/koreader that referenced this issue Feb 14, 2019
@Frenzie
[Android, fix] Fullscreen, bigger aspect ratio
07ba647 
Fixes koreader#4584

Includes koreader/android-luajit-launcher#113
@Frenzie Frenzie mentioned this issue Feb 14, 2019
Merged
Frenzie added a commit that referenced this issue Feb 14, 2019
@Frenzie
[Android, fix] Fullscreen, bigger aspect ratio (#4589)
8026ffb 
Fixes #4584

Includes koreader/android-luajit-launcher#113
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
@Frenzie @mwoz123
[Android, fix] Fullscreen, bigger aspect ratio (koreader#4589)
1ab2bc3 
Fixes koreader#4584

Includes koreader/android-luajit-launcher#113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Layout fixes pazos/android-luajit-launcher
2 participants
@Frenzie @pazos