Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout fixes #113

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Layout fixes #113

merged 2 commits into from
Feb 14, 2019

Conversation

pazos
Copy link
Member

@pazos pazos commented Feb 12, 2019

Should fix koreader/koreader#4584

I based this on ndk samples (teapots). But the sample is broken (it sets a listener on visibility changes and even then it calls setImmersiveSticky).

This also removes one of the deprecations (if google's code isnt' totally borked). I tested this on emulator 9/4.2. Can't test in 4.0.3 because google efforts to make our life harder (support for sdcard is broken).

on API19+ we set a visibility listener on onCreate
on API14-18 we set a delayed call on onResume

don't call setFullscreenLayout twice
@Frenzie
Copy link
Member

Frenzie commented Feb 12, 2019

Can't test in 4.0.3 because google efforts to make our life harder (support for sdcard is broken).

Ah, just like on 2.3.3? But at least on that one they have the excuse that they put a big fat "deprecated" on it… Not like it worked a few years ago, but whatever…

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, haven't tested it yet

@pazos
Copy link
Member Author

pazos commented Feb 12, 2019

Ah, just like on 2.3.3? But at least on that one they have the excuse that they put a big fat "deprecated" on it… Not like it worked a few years ago, but whatever…

They broke support on new android-studio-all-in-one-sdk thingy. It still works with ooold sdk tools (the standalone avdmanager).

@Frenzie: I'm not sure if it still makes sense to support fullscreen toggling. Which still works in API14-16, doesn't work at all in 16-18 and is totally unneeded on API19+.

@Frenzie
Copy link
Member

Frenzie commented Feb 13, 2019

@pazos That might depend a bit on how it all works out on some of those Android ereaders I suppose.

@pazos
Copy link
Member Author

pazos commented Feb 14, 2019

Ok, since I can't test it I will leave things as is. Last time I tested it was working fine on API15 emulator.

@Frenzie Frenzie merged commit bd0e587 into koreader:master Feb 14, 2019
@Frenzie
Copy link
Member

Frenzie commented Feb 14, 2019

Thanks!

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 14, 2019
Frenzie added a commit to koreader/koreader that referenced this pull request Feb 14, 2019
@pazos pazos deleted the layout_fixes branch December 19, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android]: Layout issues on Huawei P20 Pro
2 participants