-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout fixes #113
Layout fixes #113
Conversation
on API19+ we set a visibility listener on onCreate on API14-18 we set a delayed call on onResume don't call setFullscreenLayout twice
Ah, just like on 2.3.3? But at least on that one they have the excuse that they put a big fat "deprecated" on it… Not like it worked a few years ago, but whatever… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, haven't tested it yet
They broke support on new android-studio-all-in-one-sdk thingy. It still works with ooold sdk tools (the standalone avdmanager). @Frenzie: I'm not sure if it still makes sense to support fullscreen toggling. Which still works in API14-16, doesn't work at all in 16-18 and is totally unneeded on API19+. |
@pazos That might depend a bit on how it all works out on some of those Android ereaders I suppose. |
Ok, since I can't test it I will leave things as is. Last time I tested it was working fine on API15 emulator. |
Thanks! |
Should fix koreader/koreader#4584
I based this on ndk samples (teapots). But the sample is broken (it sets a listener on visibility changes and even then it calls setImmersiveSticky).
This also removes one of the deprecations (if google's code isnt' totally borked). I tested this on emulator 9/4.2. Can't test in 4.0.3 because google efforts to make our life harder (support for sdcard is broken).