-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange default in paged media: fit to page + scroll mode #5166
Comments
What exactly do you mean by "you get panning toward the bottom" (or top)? |
I was wrong, it's not setting the zoom mode that resets the loop, touching the top left to get the little book icon does too (but the top right folded corner does not). |
Panning toward the bottom: the top of the page is cut and at the bottom of the screen I see the interpage gray then the top of the next page; the page isn't fully scrolled, basically. |
Are you using zoom to fit page in combination with scroll mode? |
I didn't change anything (deleted my .apps/koreader then copied the one from the zip) from the defaults. No idea what the "scroll mode" is, sorry. |
Disabling scroll mode by editing defaults.lua worked but I can't find the option in the menus and https://github.com/koreader/koreader/wiki/Change-defaults is wrong, the default is 1 (I looked in the release zip). And even if this "solved" it, I wonder why the problem was there anyway. |
Sorry for being daft, finally found it on the bottom menu. |
Scroll mode can be toggled in the bottom menu. It was made the default in #2160. Perhaps zoom to page could (prompt to) turn off scroll mode. It's just that something like zoom to content or page width in combination with scroll mode by and large makes for a better experience than zoom to page. |
Don't see how it's better, but that's not the proper place to discuss that. Your prompt suggestion is a good one and should also apply to "fit to content". |
But it should, because it's scroll mode. There's an overlap with a value that will generally make it so that you would just ignore cut-off lines. Perhaps the overlap could be automatically disabled in conjunction with fit to content/page but the principle is definitely by design. The value can be adjusted to personal preference: Lines 58 to 59 in e296109
|
Oh, I see. This is not intuitive at all, at least for me. Perhaps a configuration wizard for first install should take care of these important choices. |
It's less of a choice than something that's dictated by the document in question. However, the combination of scroll mode with zoom to fit page makes for an odd default. That should probably be fit to page width, although I'd prefer content width. Alternatively it should be zoom to fit page with scroll mode off. |
Well, I think not making scroll mode the default is better simply because
that's how it is on the vendor reader. It can be especially confusing when the
document ratio matches the screen ratio (and when you can't find the bottom
menu, heh; a mention in the opening readme about the diverse menus would be
nice).
|
To be honest, I find the whole zoom/scroll/pan setup exceedingly confusing in the PDF reader, and some combinations do result in extremely odd behavior. |
@q3cpma At the same time the default in Firefox, Chromia, Evince, Okular, MuPDF, etc. is page width + scroll mode. ;-) The bottom menu automatically shows up together with the top menu. Back in 2014 I thought it was a pretty intuitive way of doing it. @NiLuJe The basic problem is that while an example such as zoom to page + scroll mode doesn't make much sense for your average "just reading along" use case, the possibilities offered by scroll mode may very well still make sense. For example, to stick a full paragraph on the screen all at once without it being split up. |
On Fri, Aug 02, 2019 at 09:46:27AM -0700, Frans de Jonge wrote:
@q3cpma At the same time the default in Firefox, Chromia, Evince, Okular, MuPDF, etc. is page width + scroll mode. ;-)
But this on LCD, not E-ink where the lag is unbearable, especially if you want
to correct any scrolling over/undershoot.
Well, now that I solved this, it's not like I really want to continue this
crusade, but I think I won't be the only one to be confused by this silent
change.
|
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <koreader#5166 (comment)>. > But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot. Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
Note that the issue I referenced was from over three years ago. I normally never scroll. You might occasionally see the top of a line that's cut off, but that's what the overlap is for. You just ignore it and flip over to the next page where the full text will be shown at the top. |
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <#5166 (comment)>. > But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot. Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <koreader#5166 (comment)>. > But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot. Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
…oreader#5170) * [UX] Change default zoom mode to page width Fixes koreader#5166. * Warning popup for weird scroll mode combinations
Hello
Issue
When reading PDFs, navigation pans the pages for no reason.
Steps to reproduce
The interesting point is that it only happens with PDFs (EPUBs and CBTs work fine) and that if I set the "Zoom mode" to "fit page" between 3) and 4), I go back to 1) (no problem while going forward).
Note that the "Zoom mode" was already set to "fit page", I just clicked on the ticked box.
Example faulty pdf: https://9p.io/sys/doc/9.pdf
I'll upload my koreader directory if nobody can reproduce.
By the way, an option to disable panning gestures would be extra nice.
The text was updated successfully, but these errors were encountered: