Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange default in paged media: fit to page + scroll mode #5166

Closed
q3cpma opened this issue Aug 2, 2019 · 17 comments · Fixed by #5170
Closed

Strange default in paged media: fit to page + scroll mode #5166

q3cpma opened this issue Aug 2, 2019 · 17 comments · Fixed by #5170
Labels

Comments

@q3cpma
Copy link

q3cpma commented Aug 2, 2019

Hello

  • KOReader version: 2019.07
  • Device: Kobo Aura HD

Issue

When reading PDFs, navigation pans the pages for no reason.

Steps to reproduce

  1. Turn 2 pages, no problem
  2. Go back 2 pages, you get panning toward to bottom each time
  3. Go back 1 page more, to return to the first page with correct layout
  4. Turn 2 pages, you get panning toward to top each time
    The interesting point is that it only happens with PDFs (EPUBs and CBTs work fine) and that if I set the "Zoom mode" to "fit page" between 3) and 4), I go back to 1) (no problem while going forward).
    Note that the "Zoom mode" was already set to "fit page", I just clicked on the ticked box.

Example faulty pdf: https://9p.io/sys/doc/9.pdf
I'll upload my koreader directory if nobody can reproduce.

By the way, an option to disable panning gestures would be extra nice.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

What exactly do you mean by "you get panning toward the bottom" (or top)?

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

I was wrong, it's not setting the zoom mode that resets the loop, touching the top left to get the little book icon does too (but the top right folded corner does not).

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

Panning toward the bottom: the top of the page is cut and at the bottom of the screen I see the interpage gray then the top of the next page; the page isn't fully scrolled, basically.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

Are you using zoom to fit page in combination with scroll mode?

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

I didn't change anything (deleted my .apps/koreader then copied the one from the zip) from the defaults. No idea what the "scroll mode" is, sorry.

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

Disabling scroll mode by editing defaults.lua worked but I can't find the option in the menus and https://github.com/koreader/koreader/wiki/Change-defaults is wrong, the default is 1 (I looked in the release zip). And even if this "solved" it, I wonder why the problem was there anyway.

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

Sorry for being daft, finally found it on the bottom menu.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

Scroll mode can be toggled in the bottom menu. It was made the default in #2160.

Perhaps zoom to page could (prompt to) turn off scroll mode. It's just that something like zoom to content or page width in combination with scroll mode by and large makes for a better experience than zoom to page.

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

Don't see how it's better, but that's not the proper place to discuss that. Your prompt suggestion is a good one and should also apply to "fit to content".
But there's still a bug here, right? Scroll mode shouldn't produce this with page turning.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

But it should, because it's scroll mode. There's an overlap with a value that will generally make it so that you would just ignore cut-off lines.

Screenshot_2019-08-02_14-14-15
Screenshot_2019-08-02_14-14-22

Perhaps the overlap could be automatically disabled in conjunction with fit to content/page but the principle is definitely by design.

The value can be adjusted to personal preference:

koreader/defaults.lua

Lines 58 to 59 in e296109

-- page overlap pixels
DOVERLAPPIXELS = 30

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019

Oh, I see. This is not intuitive at all, at least for me. Perhaps a configuration wizard for first install should take care of these important choices.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

It's less of a choice than something that's dictated by the document in question. However, the combination of scroll mode with zoom to fit page makes for an odd default. That should probably be fit to page width, although I'd prefer content width. Alternatively it should be zoom to fit page with scroll mode off.

@Frenzie Frenzie added the UX label Aug 2, 2019
@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019 via email

@NiLuJe
Copy link
Member

NiLuJe commented Aug 2, 2019

To be honest, I find the whole zoom/scroll/pan setup exceedingly confusing in the PDF reader, and some combinations do result in extremely odd behavior.

@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

@q3cpma At the same time the default in Firefox, Chromia, Evince, Okular, MuPDF, etc. is page width + scroll mode. ;-)

The bottom menu automatically shows up together with the top menu. Back in 2014 I thought it was a pretty intuitive way of doing it.

@NiLuJe The basic problem is that while an example such as zoom to page + scroll mode doesn't make much sense for your average "just reading along" use case, the possibilities offered by scroll mode may very well still make sense. For example, to stick a full paragraph on the screen all at once without it being split up.

Screenshot_2019-08-02_18-13-57

@q3cpma
Copy link
Author

q3cpma commented Aug 2, 2019 via email

Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <koreader#5166 (comment)>.

> But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot.

Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
@Frenzie
Copy link
Member

Frenzie commented Aug 2, 2019

Note that the issue I referenced was from over three years ago.

I normally never scroll. You might occasionally see the top of a line that's cut off, but that's what the overlap is for. You just ignore it and flip over to the next page where the full text will be shown at the top.

@Frenzie Frenzie changed the title Random vertical panning when navigating PDFs Strange default in paged media: fit to page + scroll mode Aug 2, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Aug 2, 2019
Frenzie added a commit that referenced this issue Aug 2, 2019
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <#5166 (comment)>.

> But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot.

Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
Frenzie added a commit that referenced this issue Aug 5, 2019
…5170)

* [UX] Change default zoom mode to page width

Fixes #5166.

* Warning popup for weird scroll mode combinations
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
The current name causes people to think of scrolling, which is slightly awkward on E Ink. For example, see <koreader#5166 (comment)>.

> But this on LCD, not E-ink where the lag is unbearable, especially if you want to correct any scrolling over/undershoot.

Scroll mode is a misnomer. It should be renamed continuous. I use "scroll mode" as the default, but I seldom or never scroll. Conversely, you can still scroll in paged mode if a page is longer than the screen. As far as I'm concerned if you're scrolling (panning) you may be doing it wrong, but to anyone reading: you do you. ;-)
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
…oreader#5170)

* [UX] Change default zoom mode to page width

Fixes koreader#5166.

* Warning popup for weird scroll mode combinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants