Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - fulltext search #4715

Merged
merged 2 commits into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 2, 2019

Fixes #4687.

@Frenzie Frenzie added the UX label Mar 2, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 2, 2019

@Frenzie Frenzie requested a review from poire-z Mar 2, 2019

end

function ReaderSearch:onShowFulltextSearchInput()
self:onInput{

This comment has been minimized.

@Frenzie

Frenzie Mar 2, 2019

Author Member

@poire-z This definitely looks tidier. Maybe dictionary/Wikipedia should also do it this way. :-)

This comment has been minimized.

@poire-z

poire-z Mar 2, 2019

Contributor

Feel free :)

end,
},
callback = function()
self:onShowSearchInput()

This comment has been minimized.

@poire-z

poire-z Mar 2, 2019

Contributor

readersearch.lua:25: attempt to call method 'onShowSearchInput' (a nil value)

This comment has been minimized.

@Frenzie

Frenzie Mar 2, 2019

Author Member

My bad, I changed the name last second because I thought it sounded too generic this way.

@poire-z

poire-z approved these changes Mar 2, 2019

@Frenzie Frenzie merged commit e96ac7e into koreader:master Mar 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesman-action-fulltext-search branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.