-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Gesture manager: add action - fulltext search #4715
[UX] Gesture manager: add action - fulltext search #4715
Conversation
end | ||
|
||
function ReaderSearch:onShowFulltextSearchInput() | ||
self:onInput{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poire-z This definitely looks tidier. Maybe dictionary/Wikipedia should also do it this way. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free :)
end, | ||
}, | ||
callback = function() | ||
self:onShowSearchInput() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readersearch.lua:25: attempt to call method 'onShowSearchInput' (a nil value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I changed the name last second because I thought it sounded too generic this way.
Fixes #4687.