Even more Gesture Manager action suggestions

[pickx]

Now that the Gesture Manager has been massively revamped, here are some more features I personally use often:

• Wikipedia lookup
• Dictionary lookup
• Toggle Reflow

There are more, but the action list is already pretty long at this point. Probably shouldn't bloat it with niche features.

[Frenzie]

Ah, reflow! I forgot about that one since fit to content width usually does the trick for me.

Fulltext search is another one that goes along with Wikipedia/Dictionary.

[gerhaher]

• Fulltext search
• Go to page
• Go to previous/next chapter

[Frenzie]

Dictionary, Wikipedia, and fulltext search would require some refactoring so they use events for showing the window. Not difficult, but not quite a quickie.

Edit: same with go to previous/next chapter but @poire-z already said he'd look into that.

[Frenzie]

• Follow nearest link

[poire-z]

Might need another to be complete (currently doable by long-press on Go back to previous location):

• Clear location stack

[Frenzie]

Would you mind doing it? :-) (I won't tonight, in any case.)

[poire-z]

ok, on it.

[poire-z]

I don't see why anybody would need this one (but I actually missed it today:):

• Exit (and why not Restart)

(@Frenzie : I feel like Exit might be tricky, I remember you spent some time on making it work correctly - so, is it? if you feel like adding it :)

Also, we have 3 forward-back-forward. The 4th one is missing: east west east - might be worth adding as the available ones by default as it's some easy to do gesture.

[Frenzie]

@poire-z It shouldn't be difficult since now you can just call the self.ui.menu:exitorRestart() method. The problem was in getting it right. ;-) Just sending a Close event around like we used to could lead to unpredictable results.

koreader/frontend/apps/filemanager/filemanagermenu.lua

Lines 375 to 401 in 5e01a0c

	function FileManagerMenu:exitOrRestart(callback)
	if SetDefaults.settings_changed then
	UIManager:show(ConfirmBox:new{
	text = _("You have unsaved default settings. Save them now?\nTap \"Cancel\" to return to KOReader."),
	ok_text = _("Save"),
	ok_callback = function()
	SetDefaults.settings_changed = false
	SetDefaults:saveSettings()
	self:exitOrRestart(callback)
	end,
	cancel_text = _("Don't save"),
	cancel_callback = function()
	SetDefaults.settings_changed = false
	self:exitOrRestart(callback)
	end,
	other_buttons = {{
	text = _("Cancel"),
	}}
	})
	else
	UIManager:close(self.menu_container)
	self.ui:onClose()
	if callback then
	callback()
	end
	end
	end

koreader/frontend/apps/reader/modules/readermenu.lua

Lines 248 to 280 in 5e01a0c

	function ReaderMenu:exitOrRestart(callback)
	if self.menu_container then self:onTapCloseMenu() end
	UIManager:nextTick(function()
	self.ui:onClose()
	if callback ~= nil then
	-- show an empty widget so that the callback always happens
	local Widget = require("ui/widget/widget")
	local widget = Widget:new{
	width = Screen:getWidth(),
	height = Screen:getHeight(),
	}
	UIManager:show(widget)
	local waiting = function(waiting)
	-- if we don't do this you can get a situation where either the
	-- program won't exit due to remaining widgets until they're
	-- dismissed or if the callback forces all widgets to close,
	-- that the save document ConfirmBox is also closed
	if self.ui and self.ui.document and self.ui.document:isEdited() then
	logger.dbg("waiting for save settings")
	UIManager:scheduleIn(1, function() waiting(waiting) end)
	else
	callback()
	UIManager:close(widget)
	end
	end
	UIManager:scheduleIn(1, function() waiting(waiting) end)
	end
	end)
	local FileManager = require("apps/filemanager/filemanager")
	if FileManager.instance then
	FileManager.instance:onClose()
	end
	end

Also, we have 3 forward-back-forward. The 4th one is missing: east west east - might be worth adding as the available ones by default as it's some easy to do gesture.

Sure. In the same obvious missing easy gestures you've got all the other diagonal ones.

Also, do you have an idea for an action on northeast, southeast, northeast? I don't have a clear vision for it like with the other gestures, but I like how it looks. :-P

[poire-z]

northeast, southeast, northeast?

Not really. Triple full refresh , to really really really remove ghosting? :)

Would we need separators in the list of gestures? (doubles same axe, double orthogonal, triples, diagonal doubles...)

[Frenzie]

If you see a simple way to add it, sure. :-)

[NiLuJe]

refreshFull() -> clear() -> refreshFull() -> forceRepaint() -> refreshFull()

(Or something to that effect :D).

Who said overkill? :D