Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frozen confirmbox when keyboard shown #5452

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix frozen confirmbox when keyboard shown #5452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5ee87
sendEvent() checks other modal widgets(if they exists) if top_widget …
mustafa-001 Oct 2, 2019
5e2190b
ckecks if widget is modal only when is_always_active fails
mustafa-001 Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions frontend/ui/uimanager.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,12 @@ function UIManager:sendEvent(event)
checked_widgets[widget] = true
if widget.widget:handleEvent(event) then return end
end
if widget.widget.modal then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it could just be an or?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a or indeed, but I don't mind the split because of the lengthy comments.
But that if might be a elseif. Dunno if a is_always_active might also be a modal, but calling twice handleEvent on a same widget, even if it returns false, might have some side effect (can't think of any right now, but logically, it could).
A or would solve this issue too, so why not :)

-- By default modal widgets are always on top but if there is more than one modal
-- widget, only last one will be top_widget.
checked_widgets[widget] = true
if widget.widget:handleEvent(event) then return end
end
end
end
end
Expand Down