Load ffi symbols individually, in protected mode #10
Conversation
To avoid conflicts with koreader-base once and for all...
IIRC, error handling in Lua involves a But even regardless of the That said, we're, comparatively, doing this for a limited number of calls, once (at require-time), so I don't expect a significant impact (and it essentially future-proofs this against future conflicting additions in base). (i.e., I'd be warier if we were doing this globally). |
|
Well yeah, even if it were more than a hundred times slower it'd probably still be fast and unproblematic. Just curious. ;-) |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
And bump lj-wpaclient to better deal with conflicts (koreader/lj-wpaclient#10)
Much easier to deal with thanks to the cleanup work done in #10062 ;). * `carrier` is set to 1 as soon as the device is *administratively* up (in practice, as soon as we run `ifconfig up`). This is perfectly fine for `isWifiOn`, but absolutely not for `isConnected`, because we are not, actually, connected to *anything*, no attempt at associating has even been made at that point. Besides being semantically wrong, in practice, this will horribly break the connectivity check, because it expects that `isConnected` means we can talk to at least the LAN. * Delving into the Linux docs reveals that `operstate` looks like a better candidate, as it reflects *operational status*; for Wi-Fi, that means associated and successfully authenticated. That's... closer, but still not it, because we still don't have an IP, so we technically can't talk to anything other than the AP. * So, I've brought out the big guns (`getifaddrs`), and replicated a bit of code that I already use in the USBNetwork hack on Kindle, to detect whether we actually have an IP assigned. (Other approaches, like `/proc/net/route`, may not be entirely fool-proof, and/or get complicated when IPv6 enters the fray (which it does, on Kobo, Mk. 8+ devices are IPv6-enabled)). TL;DR: Bunch of C via ffi, and `isConnected` now returns true only when the device is operationally up *and* we have an IP assigned. Pulls in koreader/koreader-base#1579 & koreader/lj-wpaclient#10
To avoid conflicts with koreader-base once and for all...
This change is