-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name to statemachine and make dot output stable and unique #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review - was on vacation the last two weeks :)
Please also:
- Note this as a change in the CHANGELOG.md
Signed-off-by: Pavel Pletenev <cpp.create@gmail.com>
I've implemented proposed changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs to have a run of cargo fmt
to fix up style. One optional change requested below, but I won't block merging off that.
Thanks for taking the time on this!
Looks like some tests are also failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing through on this :)
This adds ability to name statemachines. I have a personal pet project that uses smlang.
It uses several ones of them. So I wanted to see them all as pictures via graphviz.
My problem with that was: smlang-rs generates only one picture (
statemachine.svg
).Also I wanted to give each statemachine a unique name.
This patch addresses both issues.
I've also bumped the version as this change is a bit significant in my opinion. Please advise, if it should be revised.