Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to one-way error RANSAC for speed-up #1454

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

ducha-aiki
Copy link
Member

Changes

According to my tests and discussions with @danini two-way transfer error does not bring any improvements, but doubles the computation for the inlier count.
Thus I change it to one-way-error

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@ducha-aiki ducha-aiki merged commit fd67279 into master Nov 9, 2021
@ducha-aiki ducha-aiki deleted the one-way-error-ransac branch November 9, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant