Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nested AugmentationSequential containers #1467

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix for nested AugmentationSequential containers #1467

merged 1 commit into from
Nov 23, 2021

Conversation

miquelmarti
Copy link
Contributor

@miquelmarti miquelmarti commented Nov 22, 2021

Changes

Nesting AugmentationSequential containers currently fails in both forward and inverse due to the use of *args as the first argument for their forward and inverse methods and not specifying the argument names of other arguments in their calls in multiple places, as well as failing to set the return_labels flag already set in the superclass.
This PR names the arguments in calls to forward and inverse, sets the return_labels flag correctly and changes the test cases to use AugmentationSequential instead of ImageSequential to cover this in the tests.

Type of change

  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@edgarriba edgarriba added enhancement 🚀 Improvement over an existing functionality module: augmentations labels Nov 22, 2021
@edgarriba edgarriba merged commit 6bcec1b into kornia:master Nov 23, 2021
@miquelmarti miquelmarti deleted the fix/nested_aug_containers branch November 23, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 Improvement over an existing functionality module: augmentations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants