Pull request author placeholder #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to test the placeholder replacements
Adds tests for templates containing none or any of the available placeholders and verifies that they are correctly used to replace values in the way it works currently. Note, that currently it fails to replace multiple of the same placeholders.
A pull author refers to the username, not the handle of the author. So it does not contain the `@` character. We can always add this later. For reference, that could like this: ``` `pull_author_handle` | The handle of the original pull request's author, e.g. `@korthout` ```
korthout
force-pushed
the
author-placeholder
branch
from
9fea89e
to
68ea0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new placeholder ${pull_author} to be used in custom pull descriptions introduced in #64.
This placeholder will be replaced with the username of the original pull request's author (i.e. the user that created the pull request that is backported).
The placeholder can be used to mention the author, by prefixing the placeholder with the
@character. This will subscribe the mentioned user to notification of the new backport pull request. For example:Original pull request by @${pull_author}would result inOriginal pull request by @korthoutif I was the author.closes #75
Successfully tested with https://github.com/zeebe-io/automation-lab/pull/70