Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add workflow for node controller #492

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

OrangeBao
Copy link
Contributor

What type of PR is this?

/kind refactor

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@kosmos-robot
Copy link
Contributor

@OrangeBao: The label(s) kind/refactor cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind refactor

What does this PR do?

Which issue(s) does this PR fix?

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: OrangeBao <baoyinghai_yewu@cmss.chinamobile.com>

fff

Signed-off-by: OrangeBao <baoyinghai_yewu@cmss.chinamobile.com>
@OrangeBao
Copy link
Contributor Author

/lgtm

@kosmos-robot
Copy link
Contributor

@OrangeBao: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@OrangeBao
Copy link
Contributor Author

/lgtm

@kosmos-robot
Copy link
Contributor

@OrangeBao: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duanmengkk
Copy link
Contributor

/lgtm
/approve

@kosmos-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duanmengkk, OrangeBao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [OrangeBao,duanmengkk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kosmos-robot kosmos-robot merged commit ef3b9bc into kosmos-io:main Apr 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants