fix: modify some codes about the bug of namespace is int #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleichun-striving
force-pushed
the
main
branch
2 times, most recently
from
e9fdbe3
to
e6a28f1
Compare
duanmengkk
reviewed
May 9, 2024
examples/vitual-cluster-demo.yaml
Outdated
| promotePolicies: | ||
| - labelSelector: | ||
| matchLabels: | ||
| kubernetes.io/hostname: kcs-zhisuan-test-ylc-s-bkgtc |
There was a problem hiding this comment.
Suggested change
| kubernetes.io/hostname: kcs-zhisuan-test-ylc-s-bkgtc | |
| kubernetes.io/hostname: kcs-zhisuan-test-ylc-s-bkgtc |
duanmengkk
reviewed
May 9, 2024
pkg/kubenest/util/cert/certs.go
Outdated
| @@ -203,6 +203,7 @@ func apiServerAltNamesMutator(cfg *AltNamesMutatorConfig) (*certutil.AltNames, e | |||
| net.IPv4(127, 0, 0, 1), | |||
| net.IPv4(100, 71, 7, 52), | |||
There was a problem hiding this comment.
Suggested change
| net.IPv4(100, 71, 7, 52), | |
| net.IPv4(100, 71, 7, 52), |
delete
duanmengkk
reviewed
May 10, 2024
| @@ -136,10 +136,11 @@ func applyTemplatedManifests(component string, dynamicClient dynamic.Interface, | |||
| templateData := bytesData | |||
| // template doesn't suit for prometheus rules, we deploy it directly | |||
| if component != constants.PrometheusRuleManifest { | |||
| templateData, err = util.ParseTemplate(string(bytesData), templateMapping) | |||
| templateBytes, err := util.ParseTemplate(string(bytesData), templateMapping) | |||
There was a problem hiding this comment.
Suggested change
| templateBytes, err := util.ParseTemplate(string(bytesData), templateMapping) | |
| templateStr, err := util.ParseTemplate(string(bytesData), templateMapping) |
Signed-off-by: yuleichun2019 <yuleichun_yewu@cmss.chinamobile.com> modify some codes for templateString Signed-off-by: yuleichun2019 <yuleichun_yewu@cmss.chinamobile.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duanmengkk, yuleichun-striving The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do?
modify some codes about the bug of namespace is int
Which issue(s) does this PR fix?
Fixes #513
Special notes for your reviewer:
Does this PR introduce a user-facing change?