-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getMany: get multiple documents by id #10
Conversation
Wow, I work with Firestore since the day it was released and I didn't know this ability exists! Thank you so much for the PR! Sorry for nonexisting docs about contributing and testing. Let me fix that and write you an instruction on how you can run tests. |
Here we go: https://github.com/kossnocorp/typesaurus/blob/master/CONTRIBUTING.md Please tell me if you have any questions regarding it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the undefined
problem.
What do you think about the
|
Hi @kossnocorp, I added tests and fixed the |
I love it, it totally makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please accept my fixes: thomastoye#1
Add few fixes to the getMany PR
Thank you a lot for the PR! I'll ship it with a new version. |
I've shipped |
Didn't find any test instructions, some help to finish this would be appreciated :)