Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wru 2020 update (2.0.0) #101

Merged
merged 15 commits into from
Jul 12, 2023
Merged

wru 2020 update (2.0.0) #101

merged 15 commits into from
Jul 12, 2023

Conversation

mdblocker
Copy link
Contributor

Changed all defaults to 2020 data, and added a message to notify users of the year being used when pulling census data.

R/get_census_api.R Show resolved Hide resolved
R/get_census_api_2.R Show resolved Hide resolved
R/predict_race.R Outdated Show resolved Hide resolved
@mdblocker mdblocker requested a review from 1beb June 13, 2023 18:22
Copy link
Collaborator

@1beb 1beb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the binary files in src/ they are a remnant of your local build that should not be distributed with the package.

src/RcppExports.o
src/aux_funs.o
src/sample_me.o
src/wru.so

@mdblocker mdblocker requested a review from 1beb June 13, 2023 18:49
@mdblocker
Copy link
Contributor Author

@beb I rescued the afore mentioned files from the trash and added them to .gitignore instead, added one I missed. I think I have all the files dated to my commit. Unless you see one I missed I believe this is ready to go.

@1beb
Copy link
Collaborator

1beb commented Jun 20, 2023

@mdblocker Now that we've updated the defaults we need to update the tests to reflect the updates. What I would like to do is have two separate copies. One copy with the old default arg set and a new set with the updated arg that runs off of a different census data set. You'll need to recreate the data for 2020 in tests/data/census_block_nj_2010 and save it as a new file 2020.

@1beb 1beb merged commit e6ce666 into kosukeimai:main Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants