Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate output directory when input file refers to files outside (v0.5.1) #21

Closed
kotas opened this issue Mar 26, 2014 · 2 comments
Closed
Labels

Comments

@kotas
Copy link
Owner

kotas commented Mar 26, 2014

Reported by @bestander in #18 (comment)


Hi, thanks for the best gulp tsc task.
I think this pull request broke my build and I reverted to version 0.5.0.

This is my setup:

gulp.task('compile-typescript', function() {
    return gulp.src(['app/**/*.ts'])
        .pipe(cache('typescript'))
        .pipe(typescript(typescriptOptions))
        .pipe(gulp.dest(webOutputPath + '/app'));
});
gulp.task('dev', function(callback) {
    runSequence('clean-web-output',
        ['compile-typescript', 'compile-sass' ],//, 'run-tests'],
        function() {
            gulp.watch(['app/**/*.ts'], ['compile-typescript']);
        });
});

If I change one TS file I expect 1 or more JS files to be compiled into my .tmp folder.

For example if I change:

/app/online-reader/popup-reader-directive.ts

Then compiler produces this list:

<tmp>/online-reader/popup-reader-directive.js
<tmp>/online-reader/reader-preferences-service.js
<tmp>/analytics/http-latency-sampler.js

The change in this ticket changes it to:

<tmp>/online-reader/online-reader/popup-reader-directive.js
<tmp>/online-reader/online-reader/reader-preferences-service.js
<tmp>/online-reader/analytics/http-latency-sampler.js

Which os wrong.

I am happy to debug or provide more test data.

@kotas kotas added the bug label Mar 26, 2014
kotas added a commit that referenced this issue Mar 26, 2014
Fix incorrect output path when input file refers to other files
@kotas
Copy link
Owner Author

kotas commented Mar 26, 2014

Should be fixed in v0.6.0

@kotas kotas closed this as completed Mar 26, 2014
@bestander
Copy link

Tested. All good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants