EditorConfig: Actually print warning if C Core not found #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like this solution, but don't know a better one. @cg505 |
|
Why don't you like it, then? |
|
I think the change in this PR is fine but we should revamp this whole file so there isn't much point to the PR. I'll have more detail when I get home. |
|
Yes, I agree with this. To fix the issue with a message not getting displayed, I'm going to merge this. We need to come up with a better solution in general though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple fix for #51. I'm not sure if writing a message is the right way to do this, and if we wanted to use
lwarn, we could, just changing:debugto:warning. I think this follows our pattern for previous things.Closes #51.