Add Coverage reporting to coveralls.io #75
Conversation
|
Changes Unknown when pulling c1b13d6 on coverage-reporting into ** on master**. |
2 similar comments
|
Changes Unknown when pulling c1b13d6 on coverage-reporting into ** on master**. |
|
Changes Unknown when pulling c1b13d6 on coverage-reporting into ** on master**. |
|
what |
|
Changes Unknown when pulling f18f775 on coverage-reporting into ** on master**. |
1 similar comment
|
Changes Unknown when pulling f18f775 on coverage-reporting into ** on master**. |
README.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # kotct/dot | |||
|
|
|||
| [](https://travis-ci.org/kotct/dot) [](https://coveralls.io/github/kotct/dot) | |||
There was a problem hiding this comment.
Can these go on the same line as the title?
.travis.yml
Outdated
| - emacs --script .emacs.d/test/lisp/run-tests.el | ||
| - emacs --script ~/.emacs.d/init.el |
| - emacs --script .emacs.d/test/lisp/run-tests.el | ||
| - emacs --script .emacs.d/init.el |
There was a problem hiding this comment.
We had a discussion about this already, let me find it.
There was a problem hiding this comment.
Oh, my apologies, I thought there was a ~/ at the start of this path and I was very confused.
.emacs.d/test/lisp/run-tests.el
Outdated
| ;; override a local function that fixes this | ||
| (advice-add | ||
| #'undercover--wildcards-to-files :override | ||
| (lambda (wildcards) |
There was a problem hiding this comment.
I'm overriding a function that takes an argument so I need to allow an argument to be passed.
There was a problem hiding this comment.
Gotcha, does the argument need to be the same though? (Like, can you do (lambda (_) on this line instead? Or (_wildcards)?) I haven't tested this but we might get lexical binding errors, see EL manual § 11.9.4 "Using Lexical Binding":
(To silence byte-compiler warnings about unused variables, just use a variable name that start with an underscore. The byte-compiler interprets this as an indication that this is a variable known not to be used.)
If it's not used, changing it to underscore would be nice.
There was a problem hiding this comment.
We don't use lexical binding in our code, so there's no way for emacs to know if a variable is unused. That said, it probably would be good style to put the underscore anyway.
There was a problem hiding this comment.
Well, style was what I was more concerned about anyways.
| @@ -4,4 +4,7 @@ | |||
| (package-initialize) | |||
| (package-refresh-contents) | |||
|
|
|||
| ;; add undercover for coverage reporting | |||
| (setf kotct/dependency-list (cons 'undercover kotct/dependency-list)) | |||
There was a problem hiding this comment.
Erm. Any particular reason for this?
There was a problem hiding this comment.
So undercover is installed, but only on Travis (via install script instead of on init).
https://coveralls.io/github/kotct/dot
Also add badges for travis and coveralls to the readme.
This is a part of #53.