Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insertAndGenerateKey don't working. #90

Closed
ddk9499 opened this issue Feb 9, 2020 · 3 comments
Closed

insertAndGenerateKey don't working. #90

ddk9499 opened this issue Feb 9, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@ddk9499
Copy link

ddk9499 commented Feb 9, 2020

Is there any reason why used database.useTransaction method instead of database.useConnection while we call Database.insertAndGenerateKey(table, block)? Is it tested? Because, in my case, but log says everything is okey(printing effects count and generated key), transaction don't be committed.
Can anyone clarify situation. Is there bug or it's my wrong?

Database: PostgreSQL
Ktorm version: 2.7
pgDriverVersion: 42.2.9
@ddk9499
Copy link
Author

ddk9499 commented Feb 9, 2020

I have override this method in my OwnDialect and it works. I think there's bug in library.

vincentlauvlwj added a commit that referenced this issue Feb 9, 2020
@vincentlauvlwj
fix bug #90
695e27d
vincentlauvlwj added a commit that referenced this issue Feb 9, 2020
@vincentlauvlwj
fix bug #90
e6fdcb5
@vincentlauvlwj
Copy link
Member

Yes, you've found a legacy bug. I will fix it. Thank you.

@vincentlauvlwj vincentlauvlwj added the bug Something isn't working label Feb 9, 2020
@ddk9499 ddk9499 closed this as completed Feb 9, 2020
@vincentlauvlwj
Copy link
Member

Sorry that my tests didn't cover this case. I've fixed it. Please upgrade to version 2.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentlauvlwj @ddk9499