Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysis-kotlin-descriptors-1.9.10.jar is bundled with log4j:1.2.17.2 #3508

Closed
theo-ritense opened this issue Mar 1, 2024 · 4 comments · Fixed by #3592
Closed

analysis-kotlin-descriptors-1.9.10.jar is bundled with log4j:1.2.17.2 #3508

theo-ritense opened this issue Mar 1, 2024 · 4 comments · Fixed by #3592
Assignees
Labels

Comments

@theo-ritense
Copy link

theo-ritense commented Mar 1, 2024

Describe the bug
Similar to #2488

Seems that analysis-kotlin-descriptors-1.9.10.jar is bundled with log4j version 1.2.17.2. DependencyCheck is marking it CRITICAL via .gradle/caches/modules-2/files-2.1/org.jetbrains.dokka/analysis-kotlin-descriptors/1.9.10/.../analysis-kotlin-descriptors-1.9.10.jar/META-INF/maven/log4j/log4j/pom.xml

Expected behaviour
Upgrade to log4j version without security issues.

To Reproduce
Check the dependency tree

Installation

Operating system: Linux
Build tool: Gradle v8.5
Dokka version: 1.9.10 & 1.9.20

@snesm
Copy link

snesm commented Apr 19, 2024

This appears to be an issue with Dokka 1.9.20 as well

@theo-ritense
Copy link
Author

theo-ritense commented Apr 22, 2024

On a similar note, DependencyCheck also marks the following files/dependencies from 1.9.20 with a MEDIUM severity:

  • org.apache.commons:commons-compress:1.21

    • .gradle/caches/modules-2/files-2.1/org.jetbrains.dokka/analysis-kotlin-descriptors/1.9.20/.../analysis-kotlin-descriptors-1.9.20.jar/META-INF/maven/org.apache.commons/commons-compress/pom.xml
    • CVE-2024-25710
  • gfm-template-processing-plugin-1.9.20.jar

    • .gradle/caches/modules-2/files-2.1/org.jetbrains.dokka/gfm-template-processing-plugin/1.9.20/.../gfm-template-processing-plugin-1.9.20.jar
    • CVE-2018-1000840

@snesm
Copy link

snesm commented Apr 22, 2024

These seem to stem from the distribution being a fat jar which is not considered best practice because they introduce issues like this.

@theo-ritense
Copy link
Author

@whyoleg Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants