Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of factory functions using Result #263

Closed
1 of 12 tasks
Tracked by #265
LVMVRQUXL opened this issue Oct 21, 2023 · 4 comments
Closed
1 of 12 tasks
Tracked by #265

Deprecation of factory functions using Result #263

LVMVRQUXL opened this issue Oct 21, 2023 · 4 comments
Labels
common Item related to all platforms. feature New feature or request.

Comments

@LVMVRQUXL
Copy link
Contributor

LVMVRQUXL commented Oct 21, 2023

Description

Like discussed in #315, we would like to deprecate the factory functions using the Result type with a warning level.
The deprecation notices should suggest to use the public constructor of the target type instead, and should indicate that these warnings will be errors in the next minor release (see issue #265).

Finally, we should update the documentation about our design goals on error handling by explaining how we manage possible errors instead of using the Result type.

Dependencies

This issue is blocked by the following ones:

Checklist

  • Deprecate the factory functions, refactor code, update the Unreleased section in changelog and check the generated documentation for the following types:
    • NegativeInt
    • NonZeroInt
    • PositiveInt
    • StrictlyNegativeInt
    • StrictlyPositiveDouble
    • StrictlyPositiveInt
    • NotBlankString
    • NotEmptyList
    • NotEmptyMap
    • NotEmptySet
  • Update our design goals on error handling.
@LVMVRQUXL
Copy link
Contributor Author

We should split this issue by type.

@LVMVRQUXL LVMVRQUXL modified the milestones: 4.4.0, 4.5.0 Oct 25, 2023
@LVMVRQUXL LVMVRQUXL changed the title Deprecation of type converters using Result with warning level Deprecation of type converters using Result Oct 29, 2023
@LVMVRQUXL LVMVRQUXL changed the title Deprecation of type converters using Result Deprecation of factory functions using Result Oct 31, 2023
@LVMVRQUXL
Copy link
Contributor Author

The discussion #315 and its related issues will not be implemented.

@LVMVRQUXL LVMVRQUXL closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@LVMVRQUXL LVMVRQUXL removed this from the 4.4.0 milestone Dec 7, 2023
@LVMVRQUXL
Copy link
Contributor Author

LVMVRQUXL commented Dec 7, 2023

We will integrate this issue in the idea #335, but we should split this issue by type for more granularity.

@LVMVRQUXL LVMVRQUXL reopened this Dec 7, 2023
@LVMVRQUXL LVMVRQUXL added this to the 4.4.0 milestone Dec 7, 2023
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.4.0, 4.5.0 Dec 18, 2023
@LVMVRQUXL LVMVRQUXL removed this from the 4.5.0 milestone Dec 30, 2023
@LVMVRQUXL
Copy link
Contributor Author

This have been separated by types. See the topic #587.

@LVMVRQUXL LVMVRQUXL closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Item related to all platforms. feature New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant