Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation promotion of factory functions using Result to error level #265

Closed
1 of 11 tasks
Tracked by #266
LVMVRQUXL opened this issue Oct 21, 2023 · 5 comments
Closed
1 of 11 tasks
Tracked by #266

Deprecation promotion of factory functions using Result to error level #265

LVMVRQUXL opened this issue Oct 21, 2023 · 5 comments
Labels
common Item related to all platforms. feature New feature or request.

Comments

@LVMVRQUXL
Copy link
Contributor

LVMVRQUXL commented Oct 21, 2023 •
edited
Loading

Description

Like discussed in #315, we would like to promote the deprecation of the factory functions using the Result type to an error level.
The deprecation notice should indicate that these deprecated functions will be hidden in the next minor release (see issue #266).

Dependencies

This issue is blocked by the following ones:

Checklist

Promote the deprecation of the corresponding factory functions to error for the following types and update the Unreleased section in changelog:

  • NegativeInt
  • NonZeroInt
  • PositiveInt
  • StrictlyNegativeInt
  • StrictlyPositiveDouble
  • StrictlyPositiveInt
  • NotBlankString
  • NotEmptyList
  • NotEmptyMap
  • NotEmptySet
@LVMVRQUXL LVMVRQUXL added feature New feature or request. common Item related to all platforms. labels Oct 21, 2023
@LVMVRQUXL LVMVRQUXL added this to the 4.5.0 milestone Oct 21, 2023
This was referenced Oct 21, 2023
Closed
Closed
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.5.0, 4.6.0 Oct 25, 2023
@LVMVRQUXL

This comment was marked as outdated.

Sign in to view
@LVMVRQUXL LVMVRQUXL closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
@LVMVRQUXL
Copy link
Contributor Author

This issue should be implemented for following our evolution principles.

@LVMVRQUXL LVMVRQUXL reopened this Nov 24, 2023
@LVMVRQUXL LVMVRQUXL added this to the 4.5.0 milestone Nov 24, 2023
@LVMVRQUXL LVMVRQUXL changed the title Deprecation promotion of type converters using Result to error level Deprecation promotion of factory functions using Result to error level Nov 24, 2023
@LVMVRQUXL
Copy link
Contributor Author

The discussion #315 and its related issues will not be implemented.

@LVMVRQUXL LVMVRQUXL closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
@LVMVRQUXL LVMVRQUXL removed this from the 4.5.0 milestone Dec 7, 2023
@LVMVRQUXL
Copy link
Contributor Author

We will integrate this issue in the idea #335, but we should split this issue by type for more granularity.

@LVMVRQUXL LVMVRQUXL reopened this Dec 7, 2023
@LVMVRQUXL LVMVRQUXL added this to the 4.5.0 milestone Dec 7, 2023
@LVMVRQUXL LVMVRQUXL modified the milestones: 4.5.0, 4.6.0 Dec 18, 2023
@LVMVRQUXL LVMVRQUXL removed this from the 4.6.0 milestone Dec 30, 2023
@LVMVRQUXL
Copy link
Contributor Author

We are not ready to implement this change.

@LVMVRQUXL LVMVRQUXL closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
common Item related to all platforms. feature New feature or request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LVMVRQUXL