Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifi-protect: Use connectionHost to support cameras distributed between stacked nvrs #1128

Merged
merged 3 commits into from
Oct 12, 2023
Merged

unifi-protect: Use connectionHost to support cameras distributed between stacked nvrs #1128

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed01820
Use connectionHost to support cameras distributed between stacked nvrs
regaw-leinad Oct 10, 2023
b450225
Add fallback to user-configured nvr ip
regaw-leinad Oct 10, 2023
fbac58e
remove whitespace
regaw-leinad Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/unifi-protect/src/camera.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,9 @@ export class UnifiCamera extends ScryptedDeviceBase implements Notifier, Interco
const rtspChannel = camera.channels.find(check => check.id.toString() === vso.id);

const { rtspAlias } = rtspChannel;
const u = `rtsps://${this.protect.getSetting('ip')}:7441/${rtspAlias}`
// Use the camera's host from the api, otherwise fallback to user-configured nvr ip
const cameraHost = camera.connectionHost || this.protect.getSetting('ip');
const u = `rtsps://${cameraHost}:7441/${rtspAlias}`

const data = Buffer.from(JSON.stringify({
url: u,
Expand Down