Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amcrest: Add support for Dahua VTO built-in access control lock as a Lock #1356

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

rubyroobs
Copy link
Contributor

I have a Dahua VTO video intercom that works great with the Amcrest plugin, but also has a built in access control door lock/unlock mechanism that I'd like to use in automation inside of scrypted. This adds support for locking/unlocking when explicitly enabled for Dahua Doorbells.

I have tested this in my system locally and believe it will work with most standard VTO configurations, but happy to submit a video or similar if needed to get this merged.

Thanks!

@rubyroobs rubyroobs changed the title Add support for Dahua VTO locks to Amcrest plugin amcrest: Add support for Dahua VTO locks Mar 3, 2024
@rubyroobs rubyroobs changed the title amcrest: Add support for Dahua VTO locks amcrest: Add support for Dahua VTO built-in access control lock as a Lock Mar 3, 2024
@rubyroobs
Copy link
Contributor Author

Updated the title to fit what seems to be the convention - please let me know if this needs changes otherwise feel free to merge :)

@koush koush merged commit e2067c1 into koush:main Mar 3, 2024
@koush
Copy link
Owner

koush commented Mar 3, 2024

Looks good. Might be worthwhile to set this interface automatically during device creation based on probing their APIs

@rubyroobs
Copy link
Contributor Author

rubyroobs commented Mar 4, 2024

Looks good. Might be worthwhile to set this interface automatically during device creation based on probing their APIs

I intentionally kept this as something that can be toggled as the lock cannot be completely disabled on the VTO system itself. My system actually supports a "second lock" also which cannot be disabled (also annoyingly on the video intercom monitor indoors which causes confusion) but I couldn't think of a good way of making that work with the Lock interface.

Anyway, thank you for the swift review and merge! Hope this helps others too

@rubyroobs rubyroobs deleted the rubyroobs/amcrest-dahua-vto-lock branch March 4, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants