unifi: added native zoom capability #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for merge. |
koush
reviewed
Apr 3, 2023
plugins/unifi-protect/src/camera.ts
Outdated
| this.setMotionDetected(!!camera.isMotionDetected); | ||
| this.ptzCapabilities = { |
There was a problem hiding this comment.
I wouldn't set state on devices that dont implement it. server doesn't reject it nor does it send out events for it, but it will be visible/persisted if checked. scrypted allows it (currently), and maybe it shouldn't. but I think it's better to not do it in unnecessarily the first place.
There was a problem hiding this comment.
That was a miss. I will correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.