Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Initial commit for the justify-content #38

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

atapas
Copy link
Contributor

@atapas atapas commented Oct 1, 2021

Pull Request Template

Description

Created definition file for j

Fixes # (issue) # 16

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Verified that added/modified attribues are properly loading on browsing
  • Verified that added/modified attribues editing templates are properly rendered
  • Verified the putput on changes
  • Verified the deployment

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests(if any) pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Oct 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/koustov/css-builder/2HonBKfYNf9DwvemjbkDHWVxZMEe
✅ Preview: https://css-builder-git-fork-atapas-issue-16-j-defs-koustov.vercel.app

src/definitions/j.json Outdated Show resolved Hide resolved
Copy link
Owner

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@koustov koustov merged commit 8092012 into koustov:main Oct 1, 2021
@koustov koustov linked an issue Oct 1, 2021 that may be closed by this pull request
@koustov
Copy link
Owner

koustov commented Oct 1, 2021

@all-contributors please add @atapas for code

@allcontributors
Copy link
Contributor

@koustov

I've put up a pull request to add @atapas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute definition request for "J"
2 participants