Fix layout section attribute tags #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I wonder how it worked for me before. 😕 |
|
@mrueg I'm not sure but at a guess some versions of confluence might use a different XML parser that will make different assumptions about attribute prefixes. I only tested it on a quite old version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was finding that without
ac:prefix on thetypeattribute that the attribute was being ignored.I wondered if the attribute had been expected without the prefix in other versions of confluence but is appears this is correct in all the versions currently documented.
Elsewhere in the mark codebase the
ac:prefix used too. I've only tested this on a single confluence version but it seems like it should be correct for other versions.