Calculate pixel ratio in cursor_pos_callback #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed it slightly differently, to avoid needing to calculate the ratio on every callback |
|
Ah, there's a |
Closed
|
Hey @wezzynl, for me this isn't fixed yet. I'm running kitty on a Macbook Pro (2016). Could you please verify? |
This was referenced Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Retina MacBook Pro when dragging to make a selection or when trying to click a link, the x and y coordinates were off. This calculates the ratio before calling the callback. Can't test on a non-Retina screen but it should work correctly.