This repository has been archived by the owner on Mar 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
0.2.0 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added __repr__ for Request + some reformatting/refactoring
Moved the Server.handle args `clientsocket` and `address` to `request`. `Request` got 2 new attributes: `clientsocket` and `address`. Added some checks for empty requests. Added `Server.make_reply`. `Server.handle` got a new arg: `reply` `Request` requires `clientsocket` and `address` in `__init__`. `Server._recv_msg` requires the arg `address`. `Server.handle` args are `self, request, reply`.
…it__` was called In `Server._handle` if there's an Exception while running user-made `Server.handle`, it will reply with an (encrypted, encoded) [UNEXPECTEDERROR]
In `Server._handle` when calling `self.logger.error` the argument `exc_info` was `1`, but now is `True`
Co-authored-by: Sourcery AI <>
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 2.19%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress...