Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unlining pure functions #24

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Add unlining pure functions #24

merged 3 commits into from
Apr 16, 2020

Conversation

skaex
Copy link
Contributor

@skaex skaex commented Apr 10, 2020

Resolves #7

@skaex
[kowainik#7] Add 3 underlining pure functions.
59830e2 
These functions are:
- singleUnderline
- doubleUnderline
- noUnderline
hint-man[bot]
hint-man bot reviewed Apr 10, 2020
View reviewed changes
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why your PR is still not approved? Because I chose not to approve it. But they will.

src/Colourista/Pure.hs Outdated Show resolved Hide resolved
@skaex skaex force-pushed the feature/add-unlining-pure-functions branch from 50284a1 to 59830e2 Compare April 10, 2020 05:04
vrom911
vrom911 reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat work! I have only minor doc comment 👍

src/Colourista/Pure.hs
{-# SPECIALIZE singleUnderline :: Text #-}
{-# SPECIALIZE singleUnderline :: ByteString #-}

-- | Code to apply __doubleUnderline__ emphasis for the terminal output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked ansi-terminal docs, and it states that double underline doesn't work for Windows. Could you please also add this to the docs in here? 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've added that.

vrom911
vrom911 approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks 👍

@vrom911 vrom911 merged commit 9f189f7 into kowainik:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] left review comments

@vrom911 vrom911 vrom911 approved these changes

@chshersh chshersh Awaiting requested review from chshersh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add underlining pure functions
2 participants
@skaex @vrom911