Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] A lint for a lacking newline at the end of file #154

Closed
popzxc opened this issue Dec 21, 2019 · 1 comment
Closed

[RFC] A lint for a lacking newline at the end of file #154

popzxc opened this issue Dec 21, 2019 · 1 comment
Assignees
@popzxc
Labels
hint idea 💡
Milestone
v0.0.0.0: Initial...

Comments

@popzxc
Copy link
Collaborator

popzxc commented Dec 21, 2019

Since github highlights the files with the missing newline, it's a somewhat constant source of alike review comments:
NoNewlineAtTheFileEnd

It will be nice, if hintman will be able to detect those situations automatically, and provide a review comment.

I've already prototyped a solution, so if this will be considered a good idea, I'll be happy to create a corresponding PR :)
popzxc added a commit to popzxc/hintman that referenced this issue Dec 28, 2019
@popzxc
[kowainik#154] Implement no newline at file end lint
e3b4991
@popzxc popzxc mentioned this issue Dec 28, 2019
Merged
popzxc added a commit to popzxc/hintman that referenced this issue Dec 28, 2019
@popzxc
[kowainik#154] More precise phrasing in comments
271aeb3
popzxc added a commit to popzxc/hintman that referenced this issue Jan 2, 2020
@popzxc
[kowainik#154] makePrFromFork -> makePrFrom
73bf8d8
popzxc added a commit to popzxc/hintman that referenced this issue Jan 2, 2020
@popzxc
[kowainik#154] Add verbose explanations for lint
43d0342
popzxc added a commit to popzxc/hintman that referenced this issue Jan 2, 2020
@popzxc
[kowainik#154] Add test for empty file
34ee6c5
popzxc added a commit to popzxc/hintman that referenced this issue Jan 3, 2020
@popzxc
[kowainik#154] Append \n within suggestion text
54e16a9
popzxc added a commit to popzxc/hintman that referenced this issue Jan 3, 2020
@popzxc
[kowainik#154] Check that file is not empty first, and only then spli…
84dc118 
…t to lines
popzxc added a commit to popzxc/hintman that referenced this issue Jan 4, 2020
@popzxc
[kowainik#154] Take the last line only if file doesn't end with '\n'
405469a
popzxc added a commit to popzxc/hintman that referenced this issue Jan 4, 2020
@popzxc
[kowainik#154] Simplify the code
085f6de
chshersh pushed a commit that referenced this issue Jan 4, 2020
@popzxc @chshersh
[#154] "No newline at file end" lint (#156)
d32239e 
* [#154] Implement no newline at file end lint

* [#154] More precise phrasing in comments

* [#154] makePrFromFork -> makePrFrom

* [#154] Add verbose explanations for lint

* [#154] Add test for empty file

* [#154] Append \n within suggestion text

* [#154] Take the last line only if file doesn't end with '\n'

* [#154] Simplify the code
@chshersh
Copy link
Contributor

chshersh commented Jan 4, 2020

Closed in #156

@chshersh chshersh closed this as completed Jan 4, 2020
@chshersh chshersh added this to the v0.0.0.0: Initial release milestone Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@popzxc popzxc

Labels
hint idea 💡
Projects
None yet
Milestone
v0.0.0.0: Initial release
Development

No branches or pull requests
2 participants
@chshersh @popzxc