Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit failed on rebase when conflict #109

Closed
vrom911 opened this issue Sep 20, 2019 · 2 comments · Fixed by #188
Closed

Hit failed on rebase when conflict #109

vrom911 opened this issue Sep 20, 2019 · 2 comments · Fixed by #188
Assignees
Labels
bug Something isn't working Git Git commands

Comments

@vrom911
Copy link
Member

vrom911 commented Sep 20, 2019

When using hit fresh, if git rebase is not completed because of the conflict files then the command fails

hit: callCommand: git rebase origin/master (exit 128): failed

It should output instructions instead and not show the frightening error.

@vrom911 vrom911 added bug Something isn't working Git Git commands labels Sep 20, 2019
@chshersh chshersh added this to the v0.2.0.0: Refinement milestone Sep 20, 2019
@chshersh
Copy link
Contributor

@vrom911 This would be really good to do indeed! Probably the easiest solution would be to catch the specific error of git rebase command and output instructions on it.

@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@mstruebing
Copy link
Contributor

Instructions would be to modify the conflicting files, add them and do git rebase --continue.
Is this possible by Hit? Otherwise you need to switch over to git and reproduce the behavior of hit fresh manually.

@vrom911 vrom911 removed the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Jul 7, 2020
@vrom911 vrom911 self-assigned this Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Git Git commands
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants