Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter status signs #149

Closed
chshersh opened this issue Feb 23, 2020 · 1 comment · Fixed by #168
Closed

Shorter status signs #149

chshersh opened this issue Feb 23, 2020 · 1 comment · Fixed by #168
Assignees
Labels
Git Git commands

Comments

@chshersh
Copy link
Contributor

Fix #123 resulted in long status signs which overflow to a new line. Something needs to be done with this.

@chshersh chshersh added the Git Git commands label Feb 23, 2020
@chshersh chshersh added this to the v0.2.0.0: Refinement milestone Feb 23, 2020
@chshersh
Copy link
Contributor Author

chshersh commented May 4, 2020

I've accidentally discovered an easy solution to this problem. When running git diff command, you can specify a file for which you want to get statistics. So current solution can look like this:

  1. Remove max column size from this command
    diffStat <- map toStats . lines <$> "git" $| ["diff", commit, "--stat=1000", "--color=always"]
  2. Instead of running two commands, sorting files and trying to combine tables, run the second command for each file individually, get only signs from that command, and then combine results together.

@chshersh chshersh self-assigned this Jun 25, 2020
chshersh added a commit that referenced this issue Jun 25, 2020
vrom911 pushed a commit that referenced this issue Jun 25, 2020
* [#149] Shorter status signs

Resolves #149

* Fix for deleted files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Git Git commands
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant