Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Show issues from the current milestone #157

Closed
vrom911 opened this issue May 14, 2020 · 3 comments · Fixed by #169
Closed

[RFC] Show issues from the current milestone #157

vrom911 opened this issue May 14, 2020 · 3 comments · Fixed by #169
Assignees
@vrom911
Labels
question Further information is requested

Comments

@vrom911
Copy link
Member

vrom911 commented May 14, 2020

No description provided.

@vrom911 vrom911 added the question Further information is requested label May 14, 2020
@chshersh
Copy link
Contributor

Wow, I haven't thought about it! I see how this can be useful. I wonder how CLI could look like 🤔 Were you thinking about the --milestone flag for the hit issue command or a separate set of commands like hit milestone [list|create|close...]?

@vrom911
Copy link
Member Author

vrom911 commented May 14, 2020

I see how both of the options are possible and useful.
Also, the open question is how to distinguish the current milestone? By the date of creation, or the due date?
Need to think about it more 🤔

@chshersh
Copy link
Contributor

chshersh commented May 14, 2020 •
edited
Loading

I understand the dilemma and I agree that both versions are useful.
Regarding the current milestone -- I guess it makes sense that the current one is the oldest one (in terms of creation date). At least this is true for our cases. But I also can imagine cases, when it's not true. Need to think indeed...

@vrom911 vrom911 self-assigned this Jun 25, 2020
vrom911 added a commit that referenced this issue Jun 25, 2020
@vrom911
[#157] Show issues from the current milestone
2a94ec4 
Resolves #157
@vrom911 vrom911 mentioned this issue Jun 25, 2020
Merged
chshersh added a commit that referenced this issue Jun 25, 2020
@vrom911 @chshersh
[#157] Show issues from the current milestone (#169)
d6f6559 
* [#157] Show issues from the current milestone

Resolves #157

* Update src/Hit/Issue.hs

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>

* Add more useful warning messages

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#157] Show issues from the current milestone kowainik/hit-on
2 participants
@chshersh @vrom911