Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] wip commits #159

Closed
vrom911 opened this issue Jun 3, 2020 · 2 comments · Fixed by #171
Closed

[RFC] wip commits #159

vrom911 opened this issue Jun 3, 2020 · 2 comments · Fixed by #171
Assignees
Labels
question Further information is requested

Comments

@vrom911
Copy link
Member

vrom911 commented Jun 3, 2020

  • No issue numbers
  • Pushed to origin

I need this very often, so I usually do:

hit commit -np "WIP"

Would it be useful to have this logic somewhere?
I only concerned about how to handle cases with master. I guess we need to somehow create a wip branch, but not sure...

@vrom911 vrom911 added the question Further information is requested label Jun 3, 2020
@chshersh
Copy link
Contributor

chshersh commented Jun 3, 2020

@vrom911 Interesting idea! I like having hit wip command, which does exactly what you described 👍

I agree that the case with master is a bit tricky and worth thinking about 🤔 I see a few options:

  • Create <name>/wip branch (as you proposed)
    • Pros: minimal effort, not extra flags required
    • Cons: need to rename later both locally and on GitHub (we currently don't have such a command in hit); can't have multiple different wip commits from master
  • Ask the name/issue for the new branch interactively
    • Pros: better branch name immediately, more options for the user
    • Cons: slower, more flags/configuration/actions to do to create a WIP commit

@vrom911
Copy link
Member Author

vrom911 commented Jun 3, 2020

@chshersh , great summary!
For me personally the master use case is rarer, as I usually working on a particular issue and want to make a WIP commit. However, for sure the airbag should be in place. I would go for the first option, as I don't usually care about the collision between my wip branches. But the second one is totally legit. So need to think more about each one.

@chshersh chshersh added this to the v0.2.0.0: Better workflow milestone Jun 24, 2020
@chshersh chshersh self-assigned this Jun 25, 2020
chshersh added a commit that referenced this issue Jun 25, 2020
chshersh added a commit that referenced this issue Jun 25, 2020
vrom911 pushed a commit that referenced this issue Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants