Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Relude.Numeric module with integerToBounded #125

Closed
chshersh opened this issue Nov 15, 2018 · 1 comment
Closed

Add Relude.Numeric module with integerToBounded #125

chshersh opened this issue Nov 15, 2018 · 1 comment
Assignees
@sphaso
Labels
help wanted Extra attention is needed new Bring something new into library (add function or type or interface) refactoring
Milestone
v0.5.0: Improvements

Comments

@chshersh
Copy link
Contributor

This should solve specific use case of #114 Specifically:

  1. Move all number-related reexports and functions in this module.
  2. Add integerToBounded function:
integerToBounded :: forall a. (Integral a, Bounded a) => Integer -> Maybe a
  1. Add integerToNatural function there:
integerToNatural :: Integer -> Maybe Natural

  1. Reexport toIntegralSized:
@chshersh chshersh added help wanted Extra attention is needed refactoring new Bring something new into library (add function or type or interface) labels Nov 15, 2018
@chshersh chshersh added this to the v0.4.1: Improvements milestone Nov 15, 2018
@sphaso
Copy link
Contributor

sphaso commented Nov 28, 2018

I'd like to work on this if it's ok :)

@sphaso sphaso mentioned this issue Nov 29, 2018
Merged
10 tasks
chshersh pushed a commit that referenced this issue Dec 5, 2018
@sphaso @chshersh
Isolated numerical functions in Relude.Numeric (#128)
ed581b1 
* [#125] isolated numerical functions in Relude.Numeric

* style and more reexports

* fixed natural bound, style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphaso sphaso

Labels
help wanted Extra attention is needed new Bring something new into library (add function or type or interface) refactoring
Projects
None yet
Milestone
v0.5.0: Improvements
Development

No branches or pull requests
2 participants
@chshersh @sphaso