Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `Relude.Extra.Lens` module #127

Closed
chshersh opened this issue Nov 25, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@chshersh
Copy link
Member

commented Nov 25, 2018

This module should contain just very basic functions and types to work with lenses.

  • Lens'
  • lens
  • ^.
  • .~
  • %~
  • Juicy documentation with examples and usages

I personally think that lenses should be a part of base library. Fortunately, it's possible to implement small but extremely useful subset of lenses without extra dependencies. That's why packages like microlens exist. I think relude can have very small implementation of lens subset to be useful in many use-cases.

@chshersh chshersh added the extra label Nov 25, 2018

@chshersh chshersh added this to To do in #3: Hero Academia (November, 2018) via automation Nov 25, 2018

@chshersh chshersh added this to the v0.4.1: Improvements milestone Nov 25, 2018

@cronokirby

This comment has been minimized.

Copy link
Collaborator

commented Jan 14, 2019

Should we aim for compatability with Lens or not? Otherwise opting for a profunctor based implementation would be a lot simpler.

@chshersh

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2019

@cronokirby I would like for the solution to be compatible with libraries like lens and microlens. In my vision this should be possible. I need to discuss the implementation details with @vrom911 (because she is going to implement this), but otherwise we should be ok here 👍

vrom911 added a commit that referenced this issue Mar 17, 2019

vrom911 added a commit that referenced this issue Mar 17, 2019

@vrom911 vrom911 referenced this issue Mar 17, 2019

Merged

[#127] Add Lens module #152

7 of 10 tasks complete

vrom911 added a commit that referenced this issue Mar 17, 2019

vrom911 added a commit that referenced this issue Mar 17, 2019

chshersh added a commit that referenced this issue Mar 17, 2019

[#127] Add Lens module (#152)
* [#127] Add Lens module

Resolves #127

* Add Lens info to main module

* Fix stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.