Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make readFile return ByteString #22

Closed
chshersh opened this issue Jul 19, 2018 · 1 comment
Closed

Make readFile return ByteString #22

chshersh opened this issue Jul 19, 2018 · 1 comment
Assignees
@chshersh
Labels
new Bring something new into library (add function or type or interface) question Further information is requested refactoring
Milestone
v0.3.0: Combinators

Comments

@chshersh
Copy link
Contributor

And make it polymorphic.

And think more.
@chshersh chshersh added refactoring new Bring something new into library (add function or type or interface) labels Jul 19, 2018
@chshersh chshersh added the question Further information is requested label Aug 30, 2018
@chshersh
Copy link
Contributor Author

chshersh commented Aug 30, 2018 •
edited
Loading

I think here we can do similar things to Print functions. We can have:

readFileText  :: FilePath -> IO Text
readFileLText :: FilePath -> IO LText
readFileBS    :: FilePath -> IO ByteString
readFileLBS   :: FilePath -> IO LByteString

And remove default readFile?... Or make it return String as in Prelude?

@chshersh chshersh added this to the v0.3.0: Combinators milestone Sep 7, 2018
@chshersh chshersh self-assigned this Sep 9, 2018
chshersh added a commit that referenced this issue Sep 9, 2018
@chshersh
[#22] Add monomorphic functions of file functions
018b8e8
@chshersh chshersh mentioned this issue Sep 9, 2018
Merged
chshersh added a commit that referenced this issue Sep 9, 2018
@chshersh
[#22] Add monomorphic functions of file functions
857d83b
vrom911 pushed a commit that referenced this issue Sep 9, 2018
@chshersh @vrom911
[#22] Add monomorphic functions of file functions (#78)
3036697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
new Bring something new into library (add function or type or interface) question Further information is requested refactoring
Projects
None yet
Milestone
v0.3.0: Combinators
Development

No branches or pull requests
1 participant
@chshersh