Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#353] Reexport external libraries #358

Merged
merged 4 commits into from
Mar 11, 2021
Merged

[#353] Reexport external libraries #358

merged 4 commits into from
Mar 11, 2021

Conversation

chshersh
Copy link
Contributor

Resolves #353

@chshersh chshersh requested a review from vrom911 as a code owner March 11, 2021 12:49
@chshersh chshersh self-assigned this Mar 11, 2021
@chshersh chshersh added the reexport Reexport something new label Mar 11, 2021
vrom911
vrom911 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🎸
Let's try it on some of our projects just to check if everything works before the release 👌🏼

vrom911
vrom911 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the updated docs!

I think that this is quite a big feature, so we could highlight it on the top level and in the cabal description as well :) What do you think? 🐧

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
vrom911
vrom911 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🧯

@vrom911 vrom911 merged commit 727b54d into main Mar 11, 2021
@vrom911 vrom911 deleted the chshersh/353-Reexport-external-libraries branch March 11, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
reexport Reexport something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reexport external libraries
2 participants
@chshersh @vrom911