Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS to github repository generated by 'summoner' #32

Closed
chshersh opened this issue Oct 22, 2017 · 4 comments
Closed

Add CODEOWNERS to github repository generated by 'summoner' #32

chshersh opened this issue Oct 22, 2017 · 4 comments
Labels
generated project Files, folder generation by the summoner help wanted

Comments

@chshersh
Copy link
Contributor

Recent GHC introduced CODEOWNERS feature. It would be great to generate some default file for github repositories.

Example: https://github.com/serokell/importify/blob/master/CODEOWNERS

Announce: https://github.com/blog/2392-introducing-code-owners

@chshersh chshersh added Hacktoberfest https://hacktoberfest.digitalocean.com/ generated project Files, folder generation by the summoner labels Oct 22, 2017
@luvhalvorson
Copy link

Wasn't sure what you want here. I made a PR anyway, for Hacktoberfest is about to end. might look kinda silly tho. Would like to improve it if you can provide details :)

@chshersh chshersh changed the title Add CODEOWNERS to github Add CODEOWNERS to github repository generated by 'hs-init' Oct 22, 2017
@vrom911
Copy link
Member

vrom911 commented Oct 23, 2017

@chshersh thanks for this wonderful idea! It's definitely worth it to have it!
@luvhalvorson I made some comments in your PR, thank you :)

@chshersh chshersh removed the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Dec 16, 2017
@vrom911 vrom911 added this to the v1.1 Upgrade milestone May 30, 2018
@vrom911 vrom911 changed the title Add CODEOWNERS to github repository generated by 'hs-init' Add CODEOWNERS to github repository generated by 'summoner' May 30, 2018
@chshersh
Copy link
Contributor Author

Turned out it's not useful to have CODEOWNERS until we figure out how to support user vs. organization.

@vrom911
Copy link
Member

vrom911 commented Nov 28, 2018

A subtask of #41. Better to keep all of such kind in one place.
(Also it's not clear how to handle this one)

@vrom911 vrom911 closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generated project Files, folder generation by the summoner help wanted
Projects
None yet
Development

No branches or pull requests

3 participants