Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#340] Move to cabal-3.0 #555

Merged
merged 2 commits into from
Jan 11, 2022
Merged

[#340] Move to cabal-3.0 #555

merged 2 commits into from
Jan 11, 2022

Conversation

chshersh
Copy link
Contributor

Resolves #340

@chshersh chshersh self-assigned this Jan 11, 2022
@chshersh chshersh added CI CI tools support; project CI; build with different GHC, tools enhancement feature generated project Files, folder generation by the summoner labels Jan 11, 2022
vrom911
vrom911 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!
I hope old versions would work with this cabal 🤞🏼

summoner-cli/src/Summoner/Template/GitHub.hs Outdated
Comment on lines 133 to 135
ghcActionsCheckoutVersion = "@v2"
ghcActionsSetupHaskellVersion = "@v1.2"
ghcActionsCacheVersion = "@v2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it worth moving this to defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! 👍🏻

@vrom911 vrom911 merged commit b8bf784 into main Jan 11, 2022
@vrom911 vrom911 deleted the chshersh/340-Move-to-cabal-30 branch January 11, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
CI CI tools support; project CI; build with different GHC, tools enhancement feature generated project Files, folder generation by the summoner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to cabal-3.0
2 participants
@chshersh @vrom911