-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Maybe
with Either ...smth...
in BiMap
#137
Labels
Comments
Subject is about
and all derivations? |
@willbasky Yes, that's right. I assume that after refactoring this should look something like: data BiMap e a b = BiMap
{ forward :: a -> Either e b
, backward :: b -> Either e a
} And then all current type BiToml = BiMap SomeTomlError |
willbasky
added a commit
that referenced
this issue
Nov 18, 2018
willbasky
added a commit
that referenced
this issue
Nov 18, 2018
willbasky
added a commit
that referenced
this issue
Nov 18, 2018
1 task
chshersh
pushed a commit
that referenced
this issue
Jan 4, 2019
* [#137] Replace Maybe with Either in BiMap * Return Maybe and refactor * Improve Error type * Update src/Toml/BiMap.hs Co-Authored-By: willbasky <vladislav.sabanov@gmail.com> * Update src/Toml/BiMap.hs Co-Authored-By: willbasky <vladislav.sabanov@gmail.com> * Fix Error type and add more Either * Refactor 1 * Fix _NonEmpty * Refactor it * Fix matchError
chshersh
added a commit
that referenced
this issue
Jan 4, 2019
chshersh
added a commit
that referenced
this issue
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is needed to give better error messages.
The text was updated successfully, but these errors were encountered: