Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array of inline tables #145

Closed
jiegillet opened this issue Nov 13, 2018 · 2 comments · Fixed by #172
Closed

Support array of inline tables #145

jiegillet opened this issue Nov 13, 2018 · 2 comments · Fixed by #172
Assignees
@jiegillet
Labels
parser Everything related to `Text -> Toml` test Testing (unit, properties)

Comments

@jiegillet
Copy link
Collaborator

Add parser + tests for inline tables
@jiegillet jiegillet added parser Everything related to `Text -> Toml` test Testing (unit, properties) labels Nov 13, 2018
@jiegillet jiegillet self-assigned this Nov 13, 2018
@chshersh chshersh changed the title Road to Arrays of Tables - Add inline tables Support array of inline tables Jan 4, 2019
@chshersh
Copy link
Contributor

chshersh commented Jan 4, 2019

This issue is not urgent. Just a syntactic sugar. Inline tables are already supported, but not in a context of array of tables. But let's implement array of tables first, and only then we can think about array of inline tables.

@jiegillet
Copy link
Collaborator Author

jiegillet commented Jan 4, 2019 •
edited
Loading

Sure thing, this issue was always meant to be tackled after arrays of tables. Also I've had working code for this one for a while, it's just a matter of sending a PR at the right time.

@jiegillet jiegillet mentioned this issue Jan 9, 2019
Merged
chshersh pushed a commit that referenced this issue Jun 28, 2019
@jiegillet
[#145] Support for inline table arrays (#172)
6148b3c 
* Implemented inline arrays of tables

CHANGELOG

tweaked test

* WIP - fixing bugs

* [#195] Fix parser exponential behavior

* Removed double export of eof

* Changelog

* Updated documentation

* Revert Property.hs, Semigroup constraint is redundant but needed for 8.2.2

* Refactoring

* Cleaned up after merge

* Refactor and added test on spaced dotted keys

* Removed space for dotted keys

* indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiegillet jiegillet

Labels
parser Everything related to `Text -> Toml` test Testing (unit, properties)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#145] Support for inline table arrays jiegillet/tomland
2 participants
@chshersh @jiegillet